Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored and standardized are you sure modal to component #70

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

UnluckyBird
Copy link
Collaborator

Refactored repeated modal into AreYouSureModal and standardized the layout Check out the code in components/AreYouSureModal also, as I accidentally pushed this in a previous PR

No logic changes were made in this PR

UnluckyBird and others added 2 commits December 1, 2023 14:45
Refactored repeated modal into AreYouSureModal and standardized the layout
Check out the code in components/AreYouSureModal also, as I accidentally pushed this in a previous PR
Copy link
Owner

@andreasalstrup andreasalstrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UnluckyBird and others added 3 commits December 5, 2023 09:29
Rounded borders were black, meaning they weren't actually rounded. This was caused because of two View encapsulating the modal.
Copy link
Collaborator

@mikejensen0 mikejensen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fixed some styling with the modal.

@UnluckyBird UnluckyBird merged commit fc53606 into main Dec 6, 2023
1 check passed
@mikejensen0 mikejensen0 deleted the are-you-sure-modal branch December 6, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants